refactor: refactor signer and envelope to make Sign() return certs as… #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin-li
force-pushed
the
refactor-signer
branch
from
0d540da to
18fea8b
Compare
… well Signed-off-by: Binbin Li <[email protected]>
binbin-li
force-pushed
the
refactor-signer
branch
from
18fea8b to
563dc7a
Compare
JeyJeyGao
pushed a commit
to JeyJeyGao/notation-core-go
that referenced
this pull request
Sep 13, 2022
… well (notaryproject#48) Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
certsas well.Certificatesapi from Signer interface.Signed-off-by: Binbin Li [email protected]